Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751467AbbBJGWI (ORCPT ); Tue, 10 Feb 2015 01:22:08 -0500 Received: from smtprelay0095.hostedemail.com ([216.40.44.95]:56414 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750710AbbBJGWG (ORCPT ); Tue, 10 Feb 2015 01:22:06 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1981:2110:2194:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:6261:6691:10004:10400:10848:11026:11232:11658:11914:12043:12049:12296:12438:12517:12519:12555:12694:12700:12737:12740:13161:13163:13229:13255:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: birth16_2f0dc196b4a29 X-Filterd-Recvd-Size: 3846 Message-ID: <1423549321.2933.34.camel@perches.com> Subject: Re: [trivial PATCH] mod_devicetable.h: Make the definition of struct of_device_id easier to find From: Joe Perches To: Rob Herring Cc: LKML , Grant Likely , Rob Herring , Andrew Morton , Jeff Mahoney Date: Mon, 09 Feb 2015 22:22:01 -0800 In-Reply-To: References: <1423516546.2933.25.camel@perches.com> <1423538769.2933.32.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2882 Lines: 54 On Tue, 2015-02-10 at 00:11 -0600, Rob Herring wrote: > On Mon, Feb 9, 2015 at 9:26 PM, Joe Perches wrote: > > On Mon, 2015-02-09 at 19:35 -0600, Rob Herring wrote: > >> On Mon, Feb 9, 2015 at 3:15 PM, Joe Perches wrote: > >> > Move the open brace so the definition matches the more > >> > common kernel style. This makes grep a bit easier. > > > > Hey Rob. > > > >> I've got the same fix in -next for 3.20 already: > > > > Then you should push that change to Stephen's -next > > 'cause it's not there. > > Huh? I just double checked that it is in fact in 20150209. It is in next-20150209, but not in anything earlier. That'd might have been in _your_ branch, but it wasn't in linux-next as of 20150204 when I made that patch. You should make sure that Stephen merges the right branch and not want for the Linus' tagged release. There's no real reason I can see for you to wait to push your -next branch immediately. cheers, Joe $ git checkout next-20150204 HEAD is now at 29d56e4... Add linux-next specific files for 20150209 $ git log --pretty=oneline include/linux/mod_devicetable.h 32357605ce7bcd36cb6215a21cad12cd8f51b74e USB: Add missing word to comment in mod_devicetable.h de869917c663f44b5b032bff238bad22e15dda56 mod_devicetable.h: grammar fix in comment c4586256f0c440bc2bdb29d2cbb915f0ca785d26 x86: LLVMLinux: Fix "incomplete type const struct x86cpu_device_id" 158e0d3621683ee0cdfeeba56f0e5ddd97ae984f Merge tag 'driver-core-3.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core 3764e82e5150d87b205c10cd78a9c9ab86fbfa51 drivers: Introduce MEN Chameleon Bus 67bad2fdb754dbef14596c0b5d28b3a12c8dfe84 cpu: add generic support for CPU feature based module autoloading 5a86bf343976b9c8ab2f240bc866451fa67e5573 spmi: Linux driver framework for SPMI b04c99e3b845892d754ee8052d6324c39c4040de Revert "Input: introduce BTN/ABS bits for drums and guitars" 63faf15dba4a7d6fb18ed5c45670a152d0c5330b Merge branches 'for-3.12/devm', 'for-3.12/i2c-hid', 'for-3.12/i2c-hid-dt', 'for-3.12/logitech', 'for-3. 61e00655e9cb82e034eb72b95a51072e718d14a7 Input: introduce BTN/ABS bits for drums and guitars b01a60be7a4a161ac0a11df30569d21a20795aef ssb: fix alignment of struct bcma_device_id 3bdbb62fe97537252b22f700009863eeb51aa750 rapidio: add udev notification 5017b2851373ee15c7035151853bb1448800cae2 dmi: add support for exact DMI matches in addition to substring matching e5354107e14755991da82e0d2a4791db92908d9d mei: bus: Initial MEI Client bus type implementation 6543becf26fff612cdadeed7250ccc8d49f67f27 mod/file2alias: make modalias generation safe for cross compiling -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/