Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbbBJHUq (ORCPT ); Tue, 10 Feb 2015 02:20:46 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:41610 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbbBJHUo (ORCPT ); Tue, 10 Feb 2015 02:20:44 -0500 Date: Tue, 10 Feb 2015 15:20:39 +0800 From: Lee Jones To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, eddie.huang@mediatek.com, Mark Brown Subject: Re: Recommendations for a new MFD device driver? Message-ID: <20150210072039.GC8020@x1> References: <20150206101006.GK12209@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150206101006.GK12209@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 32 On Fri, 06 Feb 2015, Sascha Hauer wrote: > Hi All, > > We are adding support for a new pretty typical MFD device, the MediaTek > MT6397. Initial patches are already posted. It's a PMIC which among other > things has regulators and a RTC. The same RTC is reused on another PMIC, > but with another register offset and another interrupt. > > Now the question is where shall we put the register/irq resource > information? > > 1) Put it into the RTC device driver. > 2) Put it into the .resource field of struct mfd_cell > 3) Put it into the device tree using standard reg, interrupt properties and > a) Let the RTC driver interpret these > b) Let the MFD driver create resources in the .resource field of struct > mfd_cell > c) Let the MFD core create the resources I have no problem with 2, if that's the route you'd like to take. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/