Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbbBJI3F (ORCPT ); Tue, 10 Feb 2015 03:29:05 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:39108 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbBJI3D (ORCPT ); Tue, 10 Feb 2015 03:29:03 -0500 Message-ID: <54D9C121.3000601@huawei.com> Date: Tue, 10 Feb 2015 16:28:17 +0800 From: Wang Nan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: =?UTF-8?B?SmFudXN6IFXFvHlja2k=?= , "Jon Medhurst (Tixy)" CC: Russell King , "David A. Long" , Masami Hiramatsu , , , "Li Zefan" Subject: Re: arm: kprobe compilation error References: <54D38982.6000100@elproma.com.pl> <1423475079.2864.49.camel@linaro.org> <54D8934B.6040709@elproma.com.pl> In-Reply-To: <54D8934B.6040709@elproma.com.pl> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.69.129] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 51 On 2015/2/9 19:00, Janusz Użycki wrote: > > W dniu 2015-02-09 o 10:44, Jon Medhurst (Tixy) pisze: >> Hi Janusz >> >> On Thu, 2015-02-05 at 16:17 +0100, Janusz Użycki wrote: >>> I got the compilation error on next-20150204: >>> >> [...] >>> In file included from arch/arm/probes/kprobes/core.c:37: >>> arch/arm/probes/kprobes/core.h:43: error: '[*]' not allowed in other >>> than a declaration >> [...] >>> gcc version 4.2.4 >> Thanks for reporting this, is it OK if I add to a patch to fix this a >> line saying "Reported-by: Janusz Użycki "? > > sure > >> >> Whilst the extra '*' looks like an obvious typo, it's interesting that >> your error message implies that it's allowed in some situations and that >> the version of GCC that I use (4.9.1) doesn't complain about it. >> If it's valid C, I've no idea what that syntax that might represent. >> > I've not find such extension in C11 but likely gcc's team knows the answer. > It also compiles using gcc 4.8.3. However I thing more people use older compilers > for different platforms. > Hi All, Thanks for reporting and fixing this. When writing this code I checked C spec from open-std (n1548 and n1570). I got an feeling that [*] should be a standard way to specify variable length array types. Please see 6.7.6.3 and 6.7.7 of the spec. However I forgot there are old gccs which don't support that standard. Thank you! > best regards > Janusz > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/