Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938AbbBJJdk (ORCPT ); Tue, 10 Feb 2015 04:33:40 -0500 Received: from bes.se.axis.com ([195.60.68.10]:57146 "EHLO bes.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937AbbBJJdK (ORCPT ); Tue, 10 Feb 2015 04:33:10 -0500 Date: Tue, 10 Feb 2015 10:33:05 +0100 From: Rabin Vincent To: Tejun Heo Cc: Jesper Nilsson , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH for-3.20-fixes] workqueue: fix hang involving racing cancel[_delayed]_work_sync()'s for PREEMPT_NONE Message-ID: <20150210093305.GA6975@axis.com> References: <20150206171156.GA8942@axis.com> <20150209161527.GH3220@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150209161527.GH3220@htj.duckdns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 22 On Mon, Feb 09, 2015 at 05:15:27PM +0100, Tejun Heo wrote: > This patch removes the possible hang by updating __cancel_work_timer() > to explicitly wait for clearing of CANCELING rather than invoking > flush_work() after try_to_grab_pending() fails with -ENOENT. The > explicit wait uses the matching bit waitqueue for the CANCELING bit. > > Link: http://lkml.kernel.org/g/20150206171156.GA8942@axis.com > > Signed-off-by: Tejun Heo Fixes my synthetic test: Tested-by: Rabin Vincent Thanks. /Rabin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/