Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687AbbBJJe7 (ORCPT ); Tue, 10 Feb 2015 04:34:59 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34984 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754652AbbBJJe4 (ORCPT ); Tue, 10 Feb 2015 04:34:56 -0500 MIME-Version: 1.0 X-Originating-IP: [2401:fa00:1:fd00:51c6:ff53:3490:5a20] In-Reply-To: <1422273849-29773-1-git-send-email-addy.ke@rock-chips.com> References: <1422273849-29773-1-git-send-email-addy.ke@rock-chips.com> Date: Tue, 10 Feb 2015 01:34:55 -0800 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: fix bug that cause mmc_test failture From: Olof Johansson To: Addy Ke , Ulf Hansson Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Seungwon Jeon , Jaehoon Chung , Chris Ball , Dinh Nguyen , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Doug Anderson , Sonny Rao , amstan@chromium.org, "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-rockchip@lists.infradead.org, zhenfu.fang@rock-chips.com, Eddie Cai , lintao@rock-chips.com, chenfen@rock-chips.com, zyf@rock-chips.com, xjq@rock-chips.com, huangtao@rock-chips.com, Chris Zhong , yzq@rock-chips.com, hj@rock-chips.com, Kever Yang , zhangqing@rock-chips.com, hl@rock-chips.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 30 Hi Addy, On Mon, Jan 26, 2015 at 4:04 AM, Addy Ke wrote: > The STOP command can terminate a data transfer between a memory card and > mmc controller. > > As show in Synopsys DesignWare Cores Mobile Stroage Host Databook: > Data timeout and Data end-bit error will terminate further data transfer > by mmc controller. So we should not send abort command to terminate a > data transfer again if we got DRTO and EBE interrupt. > > After this patch, all mmc_test cases can pass on RK3288-Pink2 board. > > Signed-off-by: Addy Ke The drawback of having so many people on your to: list on a patch is that it's unclear who you want to review and merge it. Sometimes less is more. In this case, it seems appropriate to have Ulf do so. Ulf, ping? This seems like a reasonable patch for 3.20 given that it fixes undesired behavior. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/