Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755355AbbBJLqJ (ORCPT ); Tue, 10 Feb 2015 06:46:09 -0500 Received: from mail-vc0-f178.google.com ([209.85.220.178]:42282 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbBJLqH (ORCPT ); Tue, 10 Feb 2015 06:46:07 -0500 MIME-Version: 1.0 In-Reply-To: <54D52905.6040100@collabora.co.uk> References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk> <54D51170.10903@cogentembedded.com> <54D52905.6040100@collabora.co.uk> Date: Tue, 10 Feb 2015 12:46:06 +0100 X-Google-Sender-Auth: YCgHjvxCGWv3s1JAE42BYn8IYps Message-ID: Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: Sergei Shtylyov , Kukjin Kim , Andrzej Hajda , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2367 Lines: 61 2015-02-06 21:50 GMT+01:00 Javier Martinez Canillas : > Hello Sergei, > > Thanks a lot for your feedback. > > On 02/06/2015 08:09 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: >> >>> All the device nodes for the Exynos5420 power-domains have a quite >>> generic "power-domain" name. >> >> And this is in conformance to the ePAPR standard. >> > > True, I forgot that the ePAPR recommends that the node names should be > somewhat generic but OTOH this is the only Exynos DTSI file that follows > the standard for the power domain device nodes. All other Exynos DTSI > use a prefix to differentiate between each power domain. > >>> So in case of an error, the Exynos PD >>> driver shows the following (not very useful) message: >> >>> "Power domain power-domain disable failed" >> >> Why not fix the message instead to use the full device name? >> > > Well, the full node name is also not very useful IMHO since you have > to check the DTSI or SoC manual to map the device node unit-address to > the corresponding power domain. > > I used $subject when debugging an HDMI issue and instead of dropping > it, I just posted it in case someone considered useful. I don't really > mind if the patch is nacked / not picked. Additionally (on Arndale Octa): $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary domain status slaves /device runtime status ---------------------------------------------------------------------- power-domain on /devices/platform/amba/3880000.adma suspended power-domain off power-domain off power-domain off power-domain off power-domain off This really is not helpful. From the power domain debugfs code it is complicated to extract of_node of power domain. It is easier to print the name of power domain. But wait... all names are the same! :) So why do we have the name in the first place? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/