Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274AbbBJLzV (ORCPT ); Tue, 10 Feb 2015 06:55:21 -0500 Received: from mail-la0-f52.google.com ([209.85.215.52]:33234 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbbBJLzU (ORCPT ); Tue, 10 Feb 2015 06:55:20 -0500 Message-ID: <54D9F1A4.1000908@cogentembedded.com> Date: Tue, 10 Feb 2015 14:55:16 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Javier Martinez Canillas CC: Kukjin Kim , Andrzej Hajda , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk> <54D51170.10903@cogentembedded.com> <54D52905.6040100@collabora.co.uk> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2345 Lines: 62 Hello. On 2/10/2015 2:46 PM, Krzysztof Kozlowski wrote: >>>> All the device nodes for the Exynos5420 power-domains have a quite >>>> generic "power-domain" name. >>> And this is in conformance to the ePAPR standard. >> True, I forgot that the ePAPR recommends that the node names should be >> somewhat generic but OTOH this is the only Exynos DTSI file that follows >> the standard for the power domain device nodes. All other Exynos DTSI >> use a prefix to differentiate between each power domain. >>>> So in case of an error, the Exynos PD >>>> driver shows the following (not very useful) message: >>>> "Power domain power-domain disable failed" >>> Why not fix the message instead to use the full device name? >> Well, the full node name is also not very useful IMHO since you have >> to check the DTSI or SoC manual to map the device node unit-address to >> the corresponding power domain. >> I used $subject when debugging an HDMI issue and instead of dropping >> it, I just posted it in case someone considered useful. I don't really >> mind if the patch is nacked / not picked. > Additionally (on Arndale Octa): > $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary > domain status slaves > /device runtime status > ---------------------------------------------------------------------- > power-domain on > /devices/platform/amba/3880000.adma suspended > power-domain off > power-domain off > power-domain off > power-domain off > power-domain off > This really is not helpful. From the power domain debugfs code it is > complicated to extract of_node of power domain. You shouldn't need it. > It is easier to print > the name of power domain. But wait... all names are the same! :) So > why do we have the name in the first place? I'm not sure why the full platform device names aren't printed -- they should all be different. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/