Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbbBJMJw (ORCPT ); Tue, 10 Feb 2015 07:09:52 -0500 Received: from gloria.sntech.de ([95.129.55.99]:43965 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbbBJMJu (ORCPT ); Tue, 10 Feb 2015 07:09:50 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark Rutland Cc: Chris Zhong , "dianders@chromium.org" , "dtor@chromium.org" , "djkurtz@chromium.org" , "sonnyrao@chromium.org" , "linux-rockchip@lists.infradead.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] dt-bindings: add disable-wakeup property for gpio-charger Date: Tue, 10 Feb 2015 13:14:48 +0100 Message-ID: <6846904.0gWUOTnQ0A@diego> User-Agent: KMail/4.14.1 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20150210120030.GD6659@leverpostej> References: <1423555945-24289-1-git-send-email-zyw@rock-chips.com> <1423555945-24289-2-git-send-email-zyw@rock-chips.com> <20150210120030.GD6659@leverpostej> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1553 Lines: 39 Am Dienstag, 10. Februar 2015, 12:00:30 schrieb Mark Rutland: > On Tue, Feb 10, 2015 at 08:12:24AM +0000, Chris Zhong wrote: > > add disable-wakeup for gpio-charger, if you set this property, system > > will not wakeup by gpio-charger. > > > > Signed-off-by: Chris Zhong > > --- > > > > Documentation/devicetree/bindings/power_supply/gpio-charger.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt index > > adbb5dc..a46e9bc 100644 > > --- a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > +++ b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > > > @@ -4,6 +4,7 @@ Required properties : > > - compatible : "gpio-charger" > > - gpios : GPIO indicating the charger presence. > > > > See GPIO binding in bindings/gpio/gpio.txt . > > > > + - gpio-charger,disable-wakeup : Boolean, charger does not wake-up the > > system. > When would the system wake up otherwise? a response for patch 2/2 suggested to move this to userspace (as deciding if the charger should be a wakeup source is not a hardware property) and Chris responded that he'll try to move it as suggested. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/