Message-id: <1423571438.6241.4.camel@AMDC1943>
Subject: Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
        Kukjin Kim <kgene@kernel.org>, Andrzej Hajda <a.hajda@samsung.com>,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Date: Tue, 10 Feb 2015 13:30:38 +0100
In-reply-to: <54D9F7B1.3030106@cogentembedded.com>
References: <1423244258-24314-1-git-send-email-javier.martinez@collabora.co.uk>
 <54D51170.10903@cogentembedded.com> <54D52905.6040100@collabora.co.uk>
 <CAJKOXPepTJYYs6gR6NLQzsJndeRLgF+KHRpH9qt9noUgRBs2Dw@mail.gmail.com>
 <54D9F1A4.1000908@cogentembedded.com> <1423570670.6241.2.camel@AMDC1943>
 <54D9F7B1.3030106@cogentembedded.com>
Content-type: text/plain; charset=UTF-8
MIME-version: 1.0
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1849
Lines: 47

On wto, 2015-02-10 at 15:21 +0300, Sergei Shtylyov wrote:
> On 2/10/2015 3:17 PM, Krzysztof Kozlowski wrote:
> 
> >>> Additionally (on Arndale Octa):
> 
> >>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> >>>       domain                      status         slaves
> >>>              /device                                      runtime status
> >>> ----------------------------------------------------------------------
> >>> power-domain                    on
> >>>       /devices/platform/amba/3880000.adma                 suspended
> >>> power-domain                    off
> >>> power-domain                    off
> >>> power-domain                    off
> >>> power-domain                    off
> >>> power-domain                    off
> 
> >>> This really is not helpful. From the power domain debugfs code it is
> >>> complicated to extract of_node of power domain.
> 
> >>      You shouldn't need it.
> 
> >>> It is easier to print
> >>> the name of power domain. But wait... all names are the same! :) So
> >>> why do we have the name in the first place?
> 
> >>      I'm not sure why the full platform device names aren't printed -- they
> >> should all be different.
> 
> > This debugfs code iterates over list of generic_pm_domains (gpd_list). I
> > cannot find function for translating from genpd to its platform device
> > so only genpd->name can be printed.
> 
>     Then why power domains aren't just named with the platform device names?

Right, the mach-exynos/pm_domains.c set the name equal to OF node name.
I'll send a patch extending the name.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/