Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755558AbbBJMed (ORCPT ); Tue, 10 Feb 2015 07:34:33 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:42863 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbbBJMeb (ORCPT ); Tue, 10 Feb 2015 07:34:31 -0500 Date: Tue, 10 Feb 2015 12:33:57 +0000 From: Mark Rutland To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Chris Zhong , "dianders@chromium.org" , "dtor@chromium.org" , "djkurtz@chromium.org" , "sonnyrao@chromium.org" , "linux-rockchip@lists.infradead.org" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] dt-bindings: add disable-wakeup property for gpio-charger Message-ID: <20150210123357.GF6659@leverpostej> References: <1423555945-24289-1-git-send-email-zyw@rock-chips.com> <1423555945-24289-2-git-send-email-zyw@rock-chips.com> <20150210120030.GD6659@leverpostej> <6846904.0gWUOTnQ0A@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6846904.0gWUOTnQ0A@diego> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1845 Lines: 46 On Tue, Feb 10, 2015 at 12:14:48PM +0000, Heiko Stübner wrote: > Am Dienstag, 10. Februar 2015, 12:00:30 schrieb Mark Rutland: > > On Tue, Feb 10, 2015 at 08:12:24AM +0000, Chris Zhong wrote: > > > add disable-wakeup for gpio-charger, if you set this property, system > > > will not wakeup by gpio-charger. > > > > > > Signed-off-by: Chris Zhong > > > --- > > > > > > Documentation/devicetree/bindings/power_supply/gpio-charger.txt | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > > b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt index > > > adbb5dc..a46e9bc 100644 > > > --- a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > > +++ b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt > > > > > > @@ -4,6 +4,7 @@ Required properties : > > > - compatible : "gpio-charger" > > > - gpios : GPIO indicating the charger presence. > > > > > > See GPIO binding in bindings/gpio/gpio.txt . > > > > > > + - gpio-charger,disable-wakeup : Boolean, charger does not wake-up the > > > system. > > When would the system wake up otherwise? > > a response for patch 2/2 suggested to move this to userspace (as deciding if > the charger should be a wakeup source is not a hardware property) and Chris > responded that he'll try to move it as suggested. Great, that matches what I was thinking. Thanks for taking the time to say this on the DT patch. Getting part of a series makes review far more painful :( Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/