Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933418AbbBJNGI (ORCPT ); Tue, 10 Feb 2015 08:06:08 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:56508 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932447AbbBJNGG (ORCPT ); Tue, 10 Feb 2015 08:06:06 -0500 Message-ID: <54DA020C.6030703@i2se.com> Date: Tue, 10 Feb 2015 14:05:16 +0100 From: Stefan Wahren User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Fabio Estevam CC: Mike Turquette , Marek Vasut , Zhi Li , Sascha Hauer , harald@ccbib.org, Shawn Guo , linux-kernel , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KZ9nrvOnSdLVUb/kd7xV41ihM8hfG29039X3AsA7hwnIgVXpjma Na++vhUy90wMeoRZ9d2qWuX6uXgpB/FSNzBw2PFeLca1EUIcCDg73CXuNSfoIsdMjvB063p uAfIf/LS6a/weME3AQPEKlfyTFXxO3+6bcTWqlxyS1SssiZAWFLVgJi7gSuFcMwkjjGnhvw 7Uu/+Tg1eqNVjSHQ5WZ9w== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1916 Lines: 60 Hi Fabio, Am 10.02.2015 um 13:52 schrieb Fabio Estevam: > Hi Stefan, > > On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: >> According to i.MX23 and i.MX28 reference manual [1],[2] the fractional >> clock control register is 32-bit wide, but is separated in 4 parts. >> So write instructions must not apply to more than 1 part at once. >> >> The clk init for the i.MX28 violates this restriction and all the other >> accesses on that register suggest that there isn't such a restriction. >> >> This patch restricts the access to this register to byte instructions and >> extends the comment in the init functions. >> >> Btw the imx23 init now uses a R-M-W sequence just like imx28 init >> to avoid any clock glitches. >> >> The changes has been tested with a i.MX23 and a i.MX28 board. >> >> [1] - http://cache.freescale.com/files/dsp/doc/ref_manual/IMX23RM.pdf >> [2] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf >> >> Signed-off-by: Stefan Wahren >> Reviewed-by: Marek Vasut >> --- >> >> Changes in V2: >> - use relaxed access operations in clk-ref > With this patch applied mx28evk cannot probe SPI NOR flash: > > m25p80 spi1.0: unrecognized JEDEC id bytes: bf, 24, 40 > > Reverting it from linux-next, then the SPI NOR probe correctly. > > m25p80 spi1.0: sst25vf016b (2048 Kbytes) > > Any ideas? sorry no. But i will try to get a mx28evk to reproduce the problem and narrow down which part of the patch causes this problem. Did you see any problem with the clock control register settings? Stefan > > Thanks for the suggestion, Marek! > > Regards, > > Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/