Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756340AbbBJO1N (ORCPT ); Tue, 10 Feb 2015 09:27:13 -0500 Received: from mail-ie0-f170.google.com ([209.85.223.170]:46189 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755021AbbBJO1L (ORCPT ); Tue, 10 Feb 2015 09:27:11 -0500 MIME-Version: 1.0 In-Reply-To: <20150210141307.GB15593@sudip-PC> References: <1423573373-820-1-git-send-email-pushpendra.singh@smartplayin.com> <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com> <20150210141307.GB15593@sudip-PC> Date: Tue, 10 Feb 2015 15:27:11 +0100 Message-ID: Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error From: Bas Peters To: Sudip Mukherjee Cc: Pushpendra Singh , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, navin.patidar@gmail.com, gmate.amit@gmail.com, manuel.schoelling@gmx.de Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 24 >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel) >> ptr++; >> } >> } >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, >> - &pwrtrac_value); >> + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value); > you are introducing one warning to fix one error. line over 80 character. Isn't that warning more of a guideline, rather than an actual warning? This seems more readable than: - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, - &pwrtrac_value); + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, + &direction, &pwrtrac_value); Bas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/