Date: Tue, 10 Feb 2015 20:18:44 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Bas Peters <baspeters93@gmail.com>
Cc: Pushpendra Singh <pushpendra.singh@smartplayin.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, navin.patidar@gmail.com,
        gmate.amit@gmail.com, manuel.schoelling@gmx.de
Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error
Message-ID: <20150210144844.GB16435@sudip-PC>
References: <1423573373-820-1-git-send-email-pushpendra.singh@smartplayin.com>
 <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com>
 <20150210141307.GB15593@sudip-PC>
 <CAOgR63foxcQtLaaS+vEQ2BKtgHGoQHn1xiLSv=4YZf=Dy6oG3w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOgR63foxcQtLaaS+vEQ2BKtgHGoQHn1xiLSv=4YZf=Dy6oG3w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 31

On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> >>                       ptr++;
> >>               }
> >>       }
> >> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> >> -                                     &pwrtrac_value);
> >> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > you are introducing one warning to fix one error. line over 80 character.
> 
> Isn't that warning more of a guideline, rather than an actual warning?
> This seems more readable than:
> 
> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> -                                     &pwrtrac_value);
> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1,
> +
>  &direction, &pwrtrac_value);
CodingStyle says "Statements longer than 80 columns will be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does not hide information"

i agree that this is more readable but can it be called significant improvement ? but ofcourse final decision is on Greg.

sudip 
> 
> Bas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/