Message-ID: <54DA3665.40908@redhat.com>
Date: Tue, 10 Feb 2015 11:48:37 -0500
From: Rik van Riel <riel@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Frederic Weisbecker <fweisbec@gmail.com>
CC: paulmck@linux.vnet.ibm.com, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, Catalin.Marinas@arm.com,
        kvm@vger.kernel.org, mtosatti@redhat.com, borntraeger@de.ibm.com,
        mingo@kernel.org, oleg@redhat.com, lcapitulino@redhat.com,
        pbonzini@redhat.com
Subject: Re: [PATCH 1/6] rcu,nohz: add context_tracking_user_enter/exit wrapper
 functions
References: <1423579310-24555-1-git-send-email-riel@redhat.com> <1423579310-24555-2-git-send-email-riel@redhat.com> <20150210152832.GA21917@lerouge>
In-Reply-To: <20150210152832.GA21917@lerouge>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1593
Lines: 40

On 02/10/2015 10:28 AM, Frederic Weisbecker wrote:
> On Tue, Feb 10, 2015 at 09:41:45AM -0500, riel@redhat.com wrote:
>> From: Rik van Riel <riel@redhat.com>
>>
>> These wrapper functions allow architecture code (eg. ARM) to keep
>> calling context_tracking_user_enter & context_tracking_user_exit
>> the same way it always has, without error prone tricks like duplicate
>> defines of argument values in assembly code.
>>
>> Signed-off-by: Rik van Riel <riel@redhat.com>
> 
> This patch alone doesn't make much sense. 

Agreed, my goal was to keep things super easy to review,
to reduce the chance of introducing bugs.

> The changelog says it's about keeping
> context_tracking_user_*() functions as wrappers but fails to explain to what they
> wrap, why and what are the new context_tracking_enter/exit functions for.
> 
> Perhaps patches 1 and 2 should be merged together into something like:
> 
> 	context_tracking: Generalize context tracking APIs to support user and guest
> 
>         Do that because we'll also track guest....etc  And keep the old user context tracking APIs
>         for now to avoid painful enum parameter support in ARM assembly.... 

Can do...

Paul, would you like me to resend the whole series, or just
a merged patch that replaces patches 1 & 2?

That is assuming Paul prefers having the patches merged into
one :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/