Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852AbbBJQ4n (ORCPT ); Tue, 10 Feb 2015 11:56:43 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48295 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbbBJQ4l (ORCPT ); Tue, 10 Feb 2015 11:56:41 -0500 Date: Tue, 10 Feb 2015 11:56:38 -0500 From: Sowmini Varadhan To: Chuck Lever Cc: Chien Yen , davem@davemloft.net, rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rds: rds_cong_queue_updates needs to defer the congestion update transmission Message-ID: <20150210165638.GR337@oracle.com> References: <20150210142214.GO337@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 19 On (02/10/15 11:50), Chuck Lever wrote: > > > > This patch fixes a sock_lock deadlock in the rds_cong_queue_update path. > > Note that the deadlock appears to exist only with TCP transports. > True, but the patch does no harm to IB: this actually only reverts the change from commit 2fa57129d. I could update the comment to note that this is only true for TCP transports. Do you think that would help? --Sowmini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/