Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753286AbbBJRIl (ORCPT ); Tue, 10 Feb 2015 12:08:41 -0500 Received: from mail-pd0-f176.google.com ([209.85.192.176]:36989 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbbBJRIb (ORCPT ); Tue, 10 Feb 2015 12:08:31 -0500 Message-ID: <54DA3B0A.5000209@android.com> Date: Tue, 10 Feb 2015 09:08:26 -0800 From: Mark Salyzyn User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kiran Raparthy , linux-kernel@vger.kernel.org CC: Mark Salyzyn , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck Subject: Re: [RFC] pstore-ram: remove superfluous memory size check References: <1423564012-420-1-git-send-email-kumarsharma.r@gmail.com> In-Reply-To: <1423564012-420-1-git-send-email-kumarsharma.r@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2067 Lines: 64 Please refer to '[PATCH v2 2/5] pstore: remove superfluous memory size check' Sincerely -- Mark Salyzyn On 02/10/2015 02:26 AM, Kiran Raparthy wrote: > From: Mark Salyzyn > > pstore-ram: remove superfluous memory size check > > All previous checks will fail with error if memory size > is not sufficient to register a zone, so this legacy > check has become redundant. > > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Mark Salyzyn > [Kiran: Added Context] > Signed-off-by: Kiran Raparthy > > --- > This is one of the number of patches from the Android AOSP common.git tree, > which is used on Android devices. I wanted to submit it for review > to see if it should go upstream. > [PATCH v2 2/5] pstore: remove superfluous memory size check > fs/pstore/ram.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 8613e5b..34ed8f8 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -474,14 +474,6 @@ static int ramoops_probe(struct platform_device *pdev) > if (err) > goto fail_init_fprz; > > - if (!cxt->przs && !cxt->cprz && !cxt->fprz) { > - pr_err("memory size too small, minimum is %zu\n", > - cxt->console_size + cxt->record_size + > - cxt->ftrace_size); > - err = -EINVAL; > - goto fail_cnt; > - } > - > cxt->pstore.data = cxt; > /* > * Console can handle any buffer size, so prefer LOG_LINE_MAX. If we > @@ -525,7 +517,6 @@ fail_buf: > kfree(cxt->pstore.buf); > fail_clear: > cxt->pstore.bufsize = 0; > -fail_cnt: > kfree(cxt->fprz); > fail_init_fprz: > kfree(cxt->cprz); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/