Date: Tue, 10 Feb 2015 09:25:26 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Rik van Riel <riel@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, Catalin.Marinas@arm.com,
        kvm@vger.kernel.org, mtosatti@redhat.com, borntraeger@de.ibm.com,
        mingo@kernel.org, oleg@redhat.com, lcapitulino@redhat.com,
        pbonzini@redhat.com
Subject: Re: [PATCH 1/6] rcu,nohz: add context_tracking_user_enter/exit
 wrapper functions
Message-ID: <20150210172526.GQ4166@linux.vnet.ibm.com>
Reply-To: paulmck@linux.vnet.ibm.com
References: <1423579310-24555-1-git-send-email-riel@redhat.com>
 <1423579310-24555-2-git-send-email-riel@redhat.com>
 <20150210152832.GA21917@lerouge>
 <54DA3665.40908@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54DA3665.40908@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1980
Lines: 49

On Tue, Feb 10, 2015 at 11:48:37AM -0500, Rik van Riel wrote:
> On 02/10/2015 10:28 AM, Frederic Weisbecker wrote:
> > On Tue, Feb 10, 2015 at 09:41:45AM -0500, riel@redhat.com wrote:
> >> From: Rik van Riel <riel@redhat.com>
> >>
> >> These wrapper functions allow architecture code (eg. ARM) to keep
> >> calling context_tracking_user_enter & context_tracking_user_exit
> >> the same way it always has, without error prone tricks like duplicate
> >> defines of argument values in assembly code.
> >>
> >> Signed-off-by: Rik van Riel <riel@redhat.com>
> > 
> > This patch alone doesn't make much sense. 
> 
> Agreed, my goal was to keep things super easy to review,
> to reduce the chance of introducing bugs.
> 
> > The changelog says it's about keeping
> > context_tracking_user_*() functions as wrappers but fails to explain to what they
> > wrap, why and what are the new context_tracking_enter/exit functions for.
> > 
> > Perhaps patches 1 and 2 should be merged together into something like:
> > 
> > 	context_tracking: Generalize context tracking APIs to support user and guest
> > 
> >         Do that because we'll also track guest....etc  And keep the old user context tracking APIs
> >         for now to avoid painful enum parameter support in ARM assembly.... 
> 
> Can do...
> 
> Paul, would you like me to resend the whole series, or just
> a merged patch that replaces patches 1 & 2?

I prefer the whole series, as it reduces my opportunity to introduce
human error when applying them.  ;-)

> That is assuming Paul prefers having the patches merged into
> one :)

I am OK with that.  I will merge the next set with the first two patches
merged, people have had sufficient opportunity to review.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/