Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbbBJRvA (ORCPT ); Tue, 10 Feb 2015 12:51:00 -0500 Received: from arcturus.aphlor.org ([188.246.204.175]:46947 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbbBJRu7 (ORCPT ); Tue, 10 Feb 2015 12:50:59 -0500 Date: Tue, 10 Feb 2015 12:50:51 -0500 From: Dave Jones To: Peter Zijlstra Cc: Linux Kernel , Rusty Russell Subject: Re: [PATCH] module: Annotate nested sleep in resolve_symbol() Message-ID: <20150210175051.GA8288@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Peter Zijlstra , Linux Kernel , Rusty Russell References: <20150210164217.GA5547@codemonkey.org.uk> <20150210170604.GA21418@twins.programming.kicks-ass.net> <20150210171255.GQ24151@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150210171255.GQ24151@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Authenticated-User: davej@codemonkey.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 27 On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote: > On which, we should probably do this. > > --- > Subject: module: Replace over-engineered nested sleep > > Since the introduction of the nested sleep warning; we've established > that the occasional sleep inside a wait_event() is fine. > > wait_event() loops are invariant wrt. spurious wakeups, and the > occasional sleep has a similar effect on them. As long as its occasional > its harmless. > > Therefore replace the 'correct' but verbose wait_woken() thing with > a simple annotation to shut up the warning. > > Cc: Rusty Russell > Signed-off-by: Peter Zijlstra (Intel) Seems to suppress the warning, and modules still work. Tested-by: Dave Jones -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/