Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbbBJTcX (ORCPT ); Tue, 10 Feb 2015 14:32:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54699 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753843AbbBJTcV (ORCPT ); Tue, 10 Feb 2015 14:32:21 -0500 Date: Tue, 10 Feb 2015 13:32:17 -0600 From: Josh Poimboeuf To: Seth Jennings Cc: Jiri Kosina , Vojtech Pavlik , Masami Hiramatsu , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 6/9] livepatch: create per-task consistency model Message-ID: <20150210193217.GA1118@treble.redhat.com> References: <2c3d1e685dae5cccc2dfdb1b24c241b2f1c89348.1423499826.git.jpoimboe@redhat.com> <20150210192759.GA16787@cerebellum.variantweb.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150210192759.GA16787@cerebellum.variantweb.net> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 36 On Tue, Feb 10, 2015 at 01:27:59PM -0600, Seth Jennings wrote: > On Mon, Feb 09, 2015 at 11:31:18AM -0600, Josh Poimboeuf wrote: > > diff --git a/kernel/livepatch/transition.h b/kernel/livepatch/transition.h > > new file mode 100644 > > index 0000000..ba9a55c > > --- /dev/null > > +++ b/kernel/livepatch/transition.h > > @@ -0,0 +1,16 @@ > > +#include > > + > > +enum { > > + KLP_UNIVERSE_UNDEFINED = -1, > > + KLP_UNIVERSE_OLD, > > + KLP_UNIVERSE_NEW, > > +}; > > + > > +extern struct mutex klp_mutex; > > klp_mutex isn't defined in transition.c. Maybe this extern should be in > the transition.c file or in a core.h file, since core.c provides the > definition? I originally had the extern in transition.c, but then checkpatch complained so I moved it to transition.h. But yeah, it doesn't really belong there either. It's kind of ugly for transition.c to be using that mutex anyway. I think it'll be cleaner if I just move the work_fn into core.c. -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/