Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102AbbBJTeF (ORCPT ); Tue, 10 Feb 2015 14:34:05 -0500 Received: from mail-lb0-f174.google.com ([209.85.217.174]:48475 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbbBJTeD (ORCPT ); Tue, 10 Feb 2015 14:34:03 -0500 MIME-Version: 1.0 In-Reply-To: References: <250d9d48a62a2a46dba33a6f888fdd9e.squirrel@codeaurora.org> <1421181800-24323-1-git-send-email-jilaiw@codeaurora.org> Date: Tue, 10 Feb 2015 11:34:00 -0800 Message-ID: Subject: Re: [PATCH 2/2] drm/msm/hdmi: add hdmi hdcp support (V2) From: Bjorn Andersson To: Jilai Wang Cc: "dri-devel@lists.freedesktop.org" , linux-arm-msm , "linux-kernel@vger.kernel.org" , Rob Clark Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 37 On Fri, Jan 30, 2015 at 2:39 PM, Bjorn Andersson wrote: > On Fri, Jan 30, 2015 at 1:51 PM, Bjorn Andersson wrote: >> On Tue, Jan 13, 2015 at 12:43 PM, Jilai Wang wrote: >>> Add HDMI HDCP support including HDCP PartI/II/III authentication. >>> V1: Initial Change >>> V2: Address Bjorn&Rob's comments >>> Refactor the authentication process to use single work instead >>> of multiple work for different authentication stages. >>> >> Looks cleaner and the SCM parts look good now. >> >> But the ddc communication still makes me wonder, see below. >> > > Rob made me aware about the fact that the hdmi driver is both > implementing a driver for the i2c controller and now for the hdcp > client and hence doesn't have an i2c_client handle. > > So unless this is redesigned to be split in a separate i2c client > driver we probably have to have the ddc functions like this. > > I'm fine with this as is for now. > After digging some more in the i2c stack I found others using i2c_new_dummy() to create a "dummy" i2c client from and adaptor and an address. By introducing that we could make hdmi->i2c an actual i2c_client and use the client api in here. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/