Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbbBJUUj (ORCPT ); Tue, 10 Feb 2015 15:20:39 -0500 Received: from utopia.booyaka.com ([74.50.51.50]:57970 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbbBJUUi (ORCPT ); Tue, 10 Feb 2015 15:20:38 -0500 Date: Tue, 10 Feb 2015 20:20:36 +0000 (UTC) From: Paul Walmsley To: Peter Ujfalusi cc: tony@atomide.com, peterz@infradead.org, linux-omap@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2] ARM: omap2+: omap_hwmod: Set unique lock_class_key per hwmod In-Reply-To: <1423570994-20507-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: References: <1423570994-20507-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1023 Lines: 24 On Tue, 10 Feb 2015, Peter Ujfalusi wrote: > Add struct lock_class_key to omap_hwmod struct and use it to set unique > lockdep class per hwmod. > This will ensure that lockdep will know that each omap_hwmod->_lock should > be treated as separate class and will not give false warning about deadlock > or other issues due to nested use of hwmods. > DRA7x's ATL hwmod is one example for this since McASP can select ATL clock > as functional clock, which will trigger nested oh->_lock usage. This will > trigger false warning from lockdep validator as it is dealing with classes > and for it all hwmod clocks are the same class. > > Suggested-by: Peter Zijlstra > Signed-off-by: Peter Ujfalusi Thanks queued for v3.20-rc. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/