Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbbBJUbT (ORCPT ); Tue, 10 Feb 2015 15:31:19 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:55852 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbbBJUbR (ORCPT ); Tue, 10 Feb 2015 15:31:17 -0500 MIME-Version: 1.0 In-Reply-To: <87a90l7kz9.fsf@free.fr> References: <1423558107-23264-1-git-send-email-hans.holmberg@intel.com> <87a90l7kz9.fsf@free.fr> From: Tyler Hall Date: Tue, 10 Feb 2015 15:30:56 -0500 Message-ID: Subject: Re: [PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node To: Robert Jarzmik Cc: Alexandre Courbot , Hans Holmberg , Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List , Howard Cochran , Daniel Mack Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 29 On Tue, Feb 10, 2015 at 12:08 PM, Robert Jarzmik wrote: > Alexandre Courbot writes: > >> On Tue, Feb 10, 2015 at 5:48 PM, Hans Holmberg wrote: >>> The change: >>> >>> 7b8792bbdffdff3abda704f89c6a45ea97afdc62 >>> gpiolib: of: Correct error handling in of_get_named_gpiod_flags >>> >>> assumed that only one gpio-chip is registred per of-node. >>> Some drivers register more than one chip per of-node, so >>> adjust the matching function of_gpiochip_find_and_xlate to >>> not stop looking for chips if a node-match is found and >>> the translation fails. >>> >>> Signed-off-by: Hans Holmberg >> >> Acked-by: Alexandre Courbot > Tested-by: Robert Jarzmik > (on arm pxa architecture) Tested-by: Tyler Hall With gpio-pxa (multiple chips per of node) and on arm-mvebu with mvebu-gpio (one chip per of-node). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/