Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754613AbbBJWHz (ORCPT ); Tue, 10 Feb 2015 17:07:55 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:55462 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbbBJWHy (ORCPT ); Tue, 10 Feb 2015 17:07:54 -0500 X-Auth-Info: /AgWHG92rkJ70CmopWZRr/ROTEcfk4AaYXK6C7fttl4= From: Marek Vasut To: Fabio Estevam Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers Date: Tue, 10 Feb 2015 23:07:51 +0100 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) Cc: Stefan Wahren , Sascha Hauer , "linux-kernel" , Shawn Guo , Mike Turquette , "linux-arm-kernel@lists.infradead.org" , Zhi Li References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> <462270270.419156.1423603473431.JavaMail.open-xchange@oxbaltgw02.schlund.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201502102307.51740.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 43 On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote: > Hi Stefan, > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > > thanks this is very helpful. I built the linux-next for my Duckbill and > > add the SSP2 section from imx28-evk.dts into imx28-duckbill.dts. > > > > Without my patch i get the following for HW_CLKCTRL_FRAC0: > > > > ./memwatch -a 0x800401B0 > > > > 0x800401b0: 0x5e5b5513 > > > > With my patch i get: > > > > ./memwatch -a 0x800401B0 > > > > 0x800401b0: 0x5e1b5513 > > > > So it looks like a problem in my patch. > > Yes, let's try to get the same value HW_CLKCTRL_FRAC0. > > > I orded such a flash chip, but it will take some time until i can use it > > with my hardware. > > Thanks for doing this. > > Maybe if you find out a way to fix the calculation of > HW_CLKCTRL_FRAC0, then I can test it on my board. Hi, the difference is this 0x40 bit, right ? That's _STABLE bit, so it means the clock are not stable, right ? Why would that happen in the first place? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/