From: Rusty Russell <rusty@rustcorp.com.au>
To: Dave Jones <davej@codemonkey.org.uk>,
        Peter Zijlstra <peterz@infradead.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: Annotate nested sleep in resolve_symbol()
In-Reply-To: <20150210175051.GA8288@codemonkey.org.uk>
References: <20150210164217.GA5547@codemonkey.org.uk> <20150210170604.GA21418@twins.programming.kicks-ass.net> <20150210171255.GQ24151@twins.programming.kicks-ass.net> <20150210175051.GA8288@codemonkey.org.uk>
User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)
Date: Wed, 11 Feb 2015 10:18:34 +1030
Message-ID: <8761b9coq5.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1177
Lines: 33

Dave Jones <davej@codemonkey.org.uk> writes:
> On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote:
>  > On which, we should probably do this.
>  > 
>  > ---
>  > Subject: module: Replace over-engineered nested sleep 
>  > 
>  > Since the introduction of the nested sleep warning; we've established
>  > that the occasional sleep inside a wait_event() is fine.
>  > 
>  > wait_event() loops are invariant wrt. spurious wakeups, and the
>  > occasional sleep has a similar effect on them. As long as its occasional
>  > its harmless.
>  > 
>  > Therefore replace the 'correct' but verbose wait_woken() thing with
>  > a simple annotation to shut up the warning.
>  > 
>  > Cc: Rusty Russell <rusty@rustcorp.com.au>
>  > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> Seems to suppress the warning, and modules still work.
>
> Tested-by: Dave Jones <davej@codemonkey.org.uk>

OK, applied.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/