Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbbBKCuR (ORCPT ); Tue, 10 Feb 2015 21:50:17 -0500 Received: from mga14.intel.com ([192.55.52.115]:61233 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbbBKCuP (ORCPT ); Tue, 10 Feb 2015 21:50:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,555,1418112000"; d="scan'208";a="452903107" Message-ID: <54DAC363.60701@linux.intel.com> Date: Wed, 11 Feb 2015 10:50:11 +0800 From: "Fu, Zhonghui" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: "rjw@rjwysocki.net >> Rafael J. Wysocki" , pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase References: <54D8318B.2060703@linux.intel.com> <20150209215559.GA12087@kroah.com> In-Reply-To: <20150209215559.GA12087@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2568 Lines: 66 On 2015/2/10 5:55, Greg Kroah-Hartman wrote: > On Mon, Feb 09, 2015 at 12:03:23PM +0800, Fu, Zhonghui wrote: >> >From ec9c0f24e800461361eaf8b280abe4272b00772d Mon Sep 17 00:00:00 2001 >> From: Zhonghui Fu >> Date: Mon, 9 Feb 2015 11:09:22 +0800 >> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase > Why is this crud here? I will fix this in new patch. > >> Occasinally, the system can't come back up after suspend/resume >> due to problems of device suspending phase. This patch make >> PM_TRACE infrastructure cover device suspending phase of >> suspend/resume process, and the information in RTC can tell >> develpers which device suspending function make system hang. >> >> Signed-off-by: Zhonghui Fu >> --- >> arch/x86/include/asm/resume-trace.h | 2 +- >> drivers/base/power/main.c | 30 +++++++++++++++++++++--------- >> include/linux/resume-trace.h | 2 +- >> 3 files changed, 23 insertions(+), 11 deletions(-) >> >> diff --git a/arch/x86/include/asm/resume-trace.h b/arch/x86/include/asm/resume-trace.h >> index 3ff1c2c..0ca2215 100644 >> --- a/arch/x86/include/asm/resume-trace.h >> +++ b/arch/x86/include/asm/resume-trace.h >> @@ -3,7 +3,7 @@ >> >> #include >> >> -#define TRACE_RESUME(user) \ >> +#define TRACE_SUSPEND_RESUME(user) \ >> do { \ >> if (pm_trace_enabled) { \ >> const void *tracedata; \ > Why rename this? > > If you want to do that, do it in 2 different functions (rename first, > with justification, add new functionality in a second patch) Good comments, I will sent a new patch. > >> @@ -1078,7 +1082,7 @@ static int device_suspend_noirq(struct device *dev) >> { >> reinit_completion(&dev->power.completion); >> >> - if (pm_async_enabled && dev->power.async_suspend) { >> + if (is_async(dev)) { > Why change this logic? Now, PM Trace does not support asynchronous suspend/resume mode. is_async() function can inhibit async mode during using PM Trace. Thanks, Zhonghui > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/