Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbBKDfN (ORCPT ); Tue, 10 Feb 2015 22:35:13 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:42615 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbbBKDfL (ORCPT ); Tue, 10 Feb 2015 22:35:11 -0500 MIME-Version: 1.0 In-Reply-To: <1423585882-5464-1-git-send-email-matwey@sai.msu.ru> References: <1423585882-5464-1-git-send-email-matwey@sai.msu.ru> Date: Wed, 11 Feb 2015 11:35:10 +0800 Message-ID: Subject: Re: [PATCHv2 1/2] pci: spear: Use platform_driver_probe instead of platform_driver_register From: Viresh Kumar To: "Matwey V. Kornilov" Cc: Mohit KUMAR , Greg Kroah-Hartman , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 45 On 11 February 2015 at 00:31, Matwey V. Kornilov wrote: > Use platform_driver_probe instead of platform_driver_register > because the former allows us to use probe function placed into __init section > and the driver itself is not support hotplugging (yet?). > > Signed-off-by: Matwey V. Kornilov > --- > Changes from v1: > - Use platform_driver_probe instead of platform_driver_register to make linker happy. > > drivers/pci/host/pcie-spear13xx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c > index 866465f..51e1344 100644 > --- a/drivers/pci/host/pcie-spear13xx.c > +++ b/drivers/pci/host/pcie-spear13xx.c > @@ -371,7 +371,6 @@ static const struct of_device_id spear13xx_pcie_of_match[] = { > MODULE_DEVICE_TABLE(of, spear13xx_pcie_of_match); > > static struct platform_driver spear13xx_pcie_driver __initdata = { > - .probe = spear13xx_pcie_probe, > .driver = { > .name = "spear-pcie", > .of_match_table = of_match_ptr(spear13xx_pcie_of_match), > @@ -382,7 +381,7 @@ static struct platform_driver spear13xx_pcie_driver __initdata = { > > static int __init spear13xx_pcie_init(void) > { > - return platform_driver_register(&spear13xx_pcie_driver); > + return platform_driver_probe(&spear13xx_pcie_driver, spear13xx_pcie_probe); > } > module_init(spear13xx_pcie_init); The problem here is that the driver is never registered. And we might never see it in sysfs. Probably a better solution would be to just remove all __init parts from this driver. Let it take space even after it is used. And don't care about it. Sorry was busy in a conference and couldn't reply to your earlier mail on this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/