Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750984AbbBKFDi (ORCPT ); Wed, 11 Feb 2015 00:03:38 -0500 Received: from mail-ig0-f175.google.com ([209.85.213.175]:49412 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbbBKFDh (ORCPT ); Wed, 11 Feb 2015 00:03:37 -0500 From: Chris Rorvick To: Takashi Iwai Cc: Chris Rorvick , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi Subject: [PATCH 0/6] Cleanup reads/writes to Line 6 device memory Date: Tue, 10 Feb 2015 23:03:11 -0600 Message-Id: <1423630997-25464-1-git-send-email-chris@rorvick.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 35 The primary fix here is to throttle the requests for status after a read or write operation. In some cases I was seeing more than 1000 before the device was ready with a response. The remainder are smaller improvements related to the read/write logic. All of this seems pretty straightforward with the possible exception of changing the returned error from EINVAL to EIO. The EINVAL seems wrong to me but maybe not? Regards, Chris Chris Rorvick (6): ALSA: line6: Improve line6_read/write_data() interfaces ALSA: line6: Add delay before reading status ALSA: line6: Return error if device not responding ALSA: line6: Return EIO if read/write not successful ALSA: line6: Use explicit type for serial number ALSA: line6: toneport: Use explicit type for firmware version sound/usb/line6/driver.c | 51 +++++++++++++++++++++++++++++++++------------- sound/usb/line6/driver.h | 10 ++++----- sound/usb/line6/pod.c | 4 ++-- sound/usb/line6/toneport.c | 4 ++-- 4 files changed, 46 insertions(+), 23 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/