Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbbBKG4n (ORCPT ); Wed, 11 Feb 2015 01:56:43 -0500 Received: from www.osadl.org ([62.245.132.105]:58002 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbbBKG4m (ORCPT ); Wed, 11 Feb 2015 01:56:42 -0500 From: Nicholas Mc Guire To: Steven Miao Cc: Christoph Lameter , Tejun Heo , adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH RFC] blackfin: make timeout HZ independent Date: Wed, 11 Feb 2015 01:52:07 -0500 Message-Id: <1423637528-29418-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 39 The timeout is in jiffies so the hard-coded numeric value becomes HZ dependent, which is probably not the intent. To resolve this the timeout is converted with msecs_to_jiffies. Signed-off-by: Nicholas Mc Guire --- Due to tool-chain problems this patch was not even compile tested, further it is unclear if the interpretation of 5000 as 5000 milliseconds is even correct it is based on looking at other archs (e.g arch/arm64/kernel/smp.c, arch/arm/kernel/smp.c...) which use msecs_to_jiffies(5000), but other architectures use completely different timeouts. Patch is against 3.19.0 (localversion-next is -next-20150210) arch/blackfin/mach-common/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/blackfin/mach-common/smp.c b/arch/blackfin/mach-common/smp.c index 8ad3e90..8a05c32 100644 --- a/arch/blackfin/mach-common/smp.c +++ b/arch/blackfin/mach-common/smp.c @@ -417,7 +417,7 @@ static DECLARE_COMPLETION(cpu_killed); int __cpu_die(unsigned int cpu) { - return wait_for_completion_timeout(&cpu_killed, 5000); + return wait_for_completion_timeout(&cpu_killed, msecs_to_jiffies(5000)); } void cpu_die(void) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/