Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbBKIdk (ORCPT ); Wed, 11 Feb 2015 03:33:40 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50626 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbbBKIdh (ORCPT ); Wed, 11 Feb 2015 03:33:37 -0500 Date: Wed, 11 Feb 2015 11:33:28 +0300 From: Dan Carpenter To: Bas Peters Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, gmate.amit@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Pushpendra Singh , manuel.schoelling@gmx.de Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error Message-ID: <20150211083328.GJ5206@mwanda> References: <1423573373-820-1-git-send-email-pushpendra.singh@smartplayin.com> <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com> <20150210141307.GB15593@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 25 On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel) > >> ptr++; > >> } > >> } > >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, > >> - &pwrtrac_value); > >> + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value); > > you are introducing one warning to fix one error. line over 80 character. > > Isn't that warning more of a guideline, rather than an actual warning? You can't fight checkpatch.pl. We reject the worst or the worst "break lines up into smaller chunks" patches where they obviously hurt readability, but we almost always silence the warning in the end. The original code in this case was fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/