Message-ID: <1423647637.15343.16.camel@perches.com>
Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bas Peters <baspeters93@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        devel@driverdev.osuosl.org, gmate.amit@gmail.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        Pushpendra Singh <pushpendra.singh@smartplayin.com>,
        manuel.schoelling@gmx.de
Date: Wed, 11 Feb 2015 01:40:37 -0800
In-Reply-To: <20150211083328.GJ5206@mwanda>
References: <1423573373-820-1-git-send-email-pushpendra.singh@smartplayin.com>
	 <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com>
	 <20150210141307.GB15593@sudip-PC>
	 <CAOgR63foxcQtLaaS+vEQ2BKtgHGoQHn1xiLSv=4YZf=Dy6oG3w@mail.gmail.com>
	 <20150211083328.GJ5206@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 36

On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
> On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> > >>                       ptr++;
> > >>               }
> > >>       }
> > >> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> > >> -                                     &pwrtrac_value);
> > >> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > > you are introducing one warning to fix one error. line over 80 character.
> > 
> > Isn't that warning more of a guideline, rather than an actual warning?

Yes, it is more informational than defect.

> You can't fight checkpatch.pl.

Sure you can,  Ignore it whenever appropriate.

It's a pity there are _so_ many people that think
checkpatch messages are gospel.

> We reject the worst or the worst "break
> lines up into smaller chunks" patches where they obviously hurt
> readability, but we almost always silence the warning in the end.  The
> original code in this case was fine.

Any line with 30+ char identifiers generally doesn't
fit well in 80 char lines.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/