Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbbBKJxF (ORCPT ); Wed, 11 Feb 2015 04:53:05 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:38883 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbBKJxD (ORCPT ); Wed, 11 Feb 2015 04:53:03 -0500 MIME-Version: 1.0 In-Reply-To: <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> References: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org> <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> Date: Wed, 11 Feb 2015 17:53:02 +0800 Message-ID: Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type From: Ard Biesheuvel To: Ivan Khoronzhuk Cc: Matt Fleming , Leif Lindholm , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 45 On 11 February 2015 at 17:46, Ivan Khoronzhuk wrote: > According to SMBIOSv3 specification the length of DMI table can be > up to 32bits wide. So use appropriate type to avoid overflow. > > It's obvious that dmi_num theoretically can be more than u16 also, > so it's can be changed to u32 or at least it's better to use int > instead of u16, but on that moment I cannot imagine dmi structure > count more than 65535 and it can require changing type of vars that > work with it. So I didn't correct it. > > Signed-off-by: Ivan Khoronzhuk Acked-by: Ard Biesheuvel This should get a cc stable as well. -- Ard. > --- > drivers/firmware/dmi_scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c > index fb16203..952e95c 100644 > --- a/drivers/firmware/dmi_scan.c > +++ b/drivers/firmware/dmi_scan.c > @@ -18,7 +18,7 @@ > static const char dmi_empty_string[] = " "; > > static u16 __initdata dmi_ver; > -static u16 dmi_len; > +static u32 dmi_len; > static u16 dmi_num; > /* > * Catch too early calls to dmi_check_system(): > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/