Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbbBKKIF (ORCPT ); Wed, 11 Feb 2015 05:08:05 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:59830 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbBKKID (ORCPT ); Wed, 11 Feb 2015 05:08:03 -0500 Message-ID: <54DB2A01.3090808@linaro.org> Date: Wed, 11 Feb 2015 12:08:01 +0200 From: Ivan Khoronzhuk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ard Biesheuvel CC: Matt Fleming , Leif Lindholm , "linux-kernel@vger.kernel.org" Subject: Re: [Patch 3/3] firmware: dmi_scan: use full dmi version for SMBIOS3 References: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org> <1423647992-3787-4-git-send-email-ivan.khoronzhuk@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 29 On 02/11/2015 11:55 AM, Ard Biesheuvel wrote: > On 11 February 2015 at 17:46, Ivan Khoronzhuk > wrote: >> New SMBIOS3 spec adds additional field for versioning - docrev. >> The docrev identifies the revision of a specification implemented in >> the table structures, so display SMBIOS version > 3 in format, >> like: 3.22.1 >> >> It's not affect on other part of code because version number >> is analyzed using comparing, and it's obvious that 0x000208 is less >> than 0x030201 for example. >> > I don't think the spec forbids passing a 3.0+ table using the legacy > 32-bit entry point, in which case the packing of the version could > potentially become a problem. > > I don't care deeply about the docrev, so I think we could drop this > patch, but if others feel differently, could we at least pack the > version in a consistent manner (i.e., always account for docrev, and > set it to 0 if the 32-bit entry point is used?) > If others are OK, I can add docrev for 32 bit 3+ versions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/