Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbbBKKNC (ORCPT ); Wed, 11 Feb 2015 05:13:02 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:53400 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbBKKNA (ORCPT ); Wed, 11 Feb 2015 05:13:00 -0500 MIME-Version: 1.0 In-Reply-To: <54DB2A90.4070902@linaro.org> References: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org> <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> <54DB2A90.4070902@linaro.org> Date: Wed, 11 Feb 2015 18:12:59 +0800 Message-ID: Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type From: Ard Biesheuvel To: Ivan Khoronzhuk Cc: Matt Fleming , Leif Lindholm , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 38 On 11 February 2015 at 18:10, Ivan Khoronzhuk wrote: > > On 02/11/2015 11:53 AM, Ard Biesheuvel wrote: >> >> On 11 February 2015 at 17:46, Ivan Khoronzhuk >> wrote: >>> >>> According to SMBIOSv3 specification the length of DMI table can be >>> up to 32bits wide. So use appropriate type to avoid overflow. >>> >>> It's obvious that dmi_num theoretically can be more than u16 also, >>> so it's can be changed to u32 or at least it's better to use int >>> instead of u16, but on that moment I cannot imagine dmi structure >>> count more than 65535 and it can require changing type of vars that >>> work with it. So I didn't correct it. >>> >>> Signed-off-by: Ivan Khoronzhuk >> >> Acked-by: Ard Biesheuvel >> >> This should get a cc stable as well. >> > > Pay attention that this patch has to be applied with patch 1/3. Good point. Actually, I don't really see the need for patch #1, even if I agree that it would have been better to write it like you have in the first place. But leaving the dmi_len as u16 is clearly a bug on my part, so that should be fixed. @Matt: any thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/