Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbbBKKOU (ORCPT ); Wed, 11 Feb 2015 05:14:20 -0500 Received: from bhuna.collabora.co.uk ([93.93.135.160]:45306 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbbBKKNr (ORCPT ); Wed, 11 Feb 2015 05:13:47 -0500 From: Javier Martinez Canillas To: Mike Turquette Cc: Stephen Boyd , Tomeu Vizoso , =?UTF-8?q?Emilio=20L=C3=B3pez?= , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/2] clk: Don't dereference parent clock if is NULL Date: Wed, 11 Feb 2015 11:13:30 +0100 Message-Id: <1423649612-31746-2-git-send-email-javier.martinez@collabora.co.uk> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1423649612-31746-1-git-send-email-javier.martinez@collabora.co.uk> References: <1423649612-31746-1-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 32 The clock passed as an argument to clk_mux_determine_rate_flags() can not have a parent clock if is either a root clock or an orphan. In those cases parent is NULL so parent->hw shouldn't be dereferenced. Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances") Signed-off-by: Javier Martinez Canillas --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7f53166af5e6..7bd8893c94d6 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -799,7 +799,7 @@ clk_mux_determine_rate_flags(struct clk_hw *hw, unsigned long rate, /* if NO_REPARENT flag set, pass through to current parent */ if (core->flags & CLK_SET_RATE_NO_REPARENT) { parent = core->parent; - if (core->flags & CLK_SET_RATE_PARENT) + if (core->flags & CLK_SET_RATE_PARENT && parent) best = __clk_determine_rate(parent->hw, rate, min_rate, max_rate); else if (parent) -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/