Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752614AbbBKLt3 (ORCPT ); Wed, 11 Feb 2015 06:49:29 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:39582 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbbBKLt1 (ORCPT ); Wed, 11 Feb 2015 06:49:27 -0500 MIME-Version: 1.0 In-Reply-To: <54DB3D6E.5000304@users.sourceforge.net> References: <1423646233-16637-1-git-send-email-baspeters93@gmail.com> <54DB3D6E.5000304@users.sourceforge.net> Date: Wed, 11 Feb 2015 12:49:26 +0100 Message-ID: Subject: Re: [PATCH] fs: btrfs: free-space-cache.c: remove two unnecessary checks before calling kfree() From: Bas Peters To: SF Markus Elfring Cc: Chris Mason , David Sterba , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 24 2015-02-11 12:30 GMT+01:00 SF Markus Elfring : >> kfree checks whether the pointer it is passed is NULL. The two foregoing >> checks are therefore unnecessary. >> >> This issue was detected using Coccinelle. > > Would you like to integrate my update suggestion "btrfs: Deletion of > unnecessary checks before six function calls"? > https://lkml.org/lkml/2014/10/31/606 > http://article.gmane.org/gmane.linux.kernel/1818924 > https://systeme.lip6.fr/pipermail/cocci/2014-October/001321.html Oh, I see you already made the exact same change. I'll just drop my patch in that case. > > Regards, > Markus > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/