Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbbBKL6J (ORCPT ); Wed, 11 Feb 2015 06:58:09 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:54320 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbbBKL6H (ORCPT ); Wed, 11 Feb 2015 06:58:07 -0500 MIME-Version: 1.0 In-Reply-To: References: <1423630997-25464-1-git-send-email-chris@rorvick.com> <1423630997-25464-2-git-send-email-chris@rorvick.com> Date: Wed, 11 Feb 2015 05:58:06 -0600 X-Google-Sender-Auth: g6qQA7ZSnWf6d7BanH1C5J92mF8 Message-ID: Subject: Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces From: Chris Rorvick To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 17 On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai wrote: > At Tue, 10 Feb 2015 23:03:12 -0600, > Chris Rorvick wrote: >> >> Use explicit types to reflect the range of valid values. > > Well, this isn't necessarily to be changed at these places. If we > want to be safer, there should be proper range checks instead. > Also, readers may wonder when they see the different types between > read and write without explanations. Thanks, I'll send a v2 shortly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/