Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbbBKMKw (ORCPT ); Wed, 11 Feb 2015 07:10:52 -0500 Received: from mout.web.de ([212.227.15.14]:50134 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbbBKMKv (ORCPT ); Wed, 11 Feb 2015 07:10:51 -0500 Message-ID: <54DB46BA.7020803@users.sourceforge.net> Date: Wed, 11 Feb 2015 13:10:34 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bas Peters , Christine Caulfield , David Teigland CC: cluster-devel@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] fs: dlm: lockspace.c: removal of unnecessary check before calling kfree() References: <1423646814-22720-1-git-send-email-baspeters93@gmail.com> In-Reply-To: <1423646814-22720-1-git-send-email-baspeters93@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qNu4MHaPzsZpn9o/UUZCFa4TPWw4rO8HQ25e09ECr9lor+zXkld GuP6peaizoLauJx4Emkz4/AUyRXPHivZg9PyYUfzz5x2LuWNnT5FDzifkLcxI0xAIboLxF0 YC7WsKAyQCEy96LbuWgvhPFQg+u5intyDnDfWS21Z3x5k5pwadiFTdAzVox0rAT2VTczjY5 lYjwX1nQWE52JoLVR4xtA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 18 > kfree() checks its argument. It is therefore unnecessary to do this twice. > > This issue was detected using Coccinelle. Would you like to integrate my update suggestion 'fs-DLM: Deletion of unnecessary checks before the function call "kfree"'? https://lkml.org/lkml/2014/11/29/88 http://article.gmane.org/gmane.linux.kernel/1840524 https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg778279.html Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/