Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752354AbbBKMNA (ORCPT ); Wed, 11 Feb 2015 07:13:00 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:54044 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbBKMM6 (ORCPT ); Wed, 11 Feb 2015 07:12:58 -0500 MIME-Version: 1.0 In-Reply-To: <54DB46BA.7020803@users.sourceforge.net> References: <1423646814-22720-1-git-send-email-baspeters93@gmail.com> <54DB46BA.7020803@users.sourceforge.net> Date: Wed, 11 Feb 2015 13:12:57 +0100 Message-ID: Subject: Re: [PATCH] fs: dlm: lockspace.c: removal of unnecessary check before calling kfree() From: Bas Peters To: SF Markus Elfring Cc: Christine Caulfield , David Teigland , cluster-devel@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 21 2015-02-11 13:10 GMT+01:00 SF Markus Elfring : >> kfree() checks its argument. It is therefore unnecessary to do this twice. >> >> This issue was detected using Coccinelle. > > Would you like to integrate my update suggestion 'fs-DLM: Deletion of > unnecessary checks before the function call "kfree"'? > https://lkml.org/lkml/2014/11/29/88 > http://article.gmane.org/gmane.linux.kernel/1840524 > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg778279.html I'll drop that too :) > Regards, > Markus > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/