Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbbBKP1V (ORCPT ); Wed, 11 Feb 2015 10:27:21 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:61993 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbbBKP1T (ORCPT ); Wed, 11 Feb 2015 10:27:19 -0500 Message-ID: <54DB74D5.2040607@gmail.com> Date: Wed, 11 Feb 2015 08:27:17 -0700 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stephane Eranian , linux-kernel@vger.kernel.org CC: acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, cel@us.ibm.com, sukadev@linux.vnet.ibm.com, sonnyrao@chromium.org, johnmccutchan@google.com Subject: Re: [PATCH 3/4] perf inject: add jitdump mmap injection support References: <1423611765-18200-1-git-send-email-eranian@google.com> <1423611765-18200-4-git-send-email-eranian@google.com> In-Reply-To: <1423611765-18200-4-git-send-email-eranian@google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 32 On 2/10/15 4:42 PM, Stephane Eranian wrote: > diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt > index dc7442c..237f195 100644 > --- a/tools/perf/Documentation/perf-inject.txt > +++ b/tools/perf/Documentation/perf-inject.txt > @@ -40,6 +40,17 @@ OPTIONS > Merge sched_stat and sched_switch for getting events where and how long > tasks slept. sched_switch contains a callchain where a task slept and > sched_stat contains a timeslice how long a task slept. > +-j:: > +--jit:: > + Merge a jitdump file into the perf.data file by adding mmap records to > + cover jitted code and emit ELF images for each jitted function. The ELF > + images are saved in the same directory as the jidump. Use -E to suppress > + ELF images generation. > +-E:: > +--jit-disable-elf:: > + When used with -, it prevents creating the ELF images for each jitted > + function. Only the jitted code mmap records are injected into the perf.data > + file. Option as no effect when -j is not used. s/as/has/. But it would better to avoid the double negative. Maye something like this instead: This option requires -j|--jit. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/