Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753261AbbBKP5m (ORCPT ); Wed, 11 Feb 2015 10:57:42 -0500 Received: from casper.infradead.org ([85.118.1.10]:38973 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbBKP5k (ORCPT ); Wed, 11 Feb 2015 10:57:40 -0500 Date: Wed, 11 Feb 2015 15:57:38 +0000 From: Thomas Graf To: Geert Uytterhoeven Cc: "David S. Miller" , Pravin Shelar , netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun() Message-ID: <20150211155738.GB29155@casper.infradead.org> References: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 18 On 02/11/15 at 11:23am, Geert Uytterhoeven wrote: > net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’: > net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function > > If ipv4_tun_from_nlattr() returns a different positive value than > OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and > validate_and_copy_set_tun() may return an undefined value instead of a > zero success indicator. Initialize err to zero to fix this. > > Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension") > Signed-off-by: Geert Uytterhoeven Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/