Date: Wed, 11 Feb 2015 11:05:42 -0700
From: Gilad Avidov <gavidov@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org,
        linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, iivanov@mm-sol.com, galak@codeaurora.org,
        agross@codeaurora.org
Subject: Re: [PATCH V3 0/2] add support for pmic_arb v2 and correct
 framework
Message-ID: <20150211110542.4e6d7218@gavidov-lnx.qualcomm.com>
In-Reply-To: <54D93E0A.9000703@codeaurora.org>
References: <1423522272-24472-1-git-send-email-gavidov@codeaurora.org>
	<54D93E0A.9000703@codeaurora.org>
Organization: Qualcomm Innovation Center, Inc.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1460
Lines: 43

On Mon, 09 Feb 2015 15:08:58 -0800
Stephen Boyd <sboyd@codeaurora.org> wrote:

> On 02/09/15 14:51, Gilad Avidov wrote:
> > pmic_arb v2 has no support for spmi non-data commands and thus
> > returns -EOPNOTSUPP on .cmd callback. This causes a failure in
> > spmi_drv_probe() which sends a wakeup command to the slave before
> > probing its driver. This patchset removes the wakeup from
> > spmi_drv_probe() since the spmi spec stipulates that a slaves
> > default state is active and doesn't need a wakeup.
> 
> The spec also seems to stipulate that SPMI masters shall support all
> SPMI command sequences.

Regardless of the master's support, a wakeup call before prob is not
required.

> 
> > Gilad Avidov (2):
> >   spmi: remove wakeup command before slave probe
> >   spmi: pmic_arb: add support for hw version 2
> >
> >  .../bindings/spmi/qcom,spmi-pmic-arb.txt           |   6 +-
> >  drivers/spmi/spmi-pmic-arb.c                       | 312
> > +++++++++++++++++----
> > drivers/spmi/spmi.c                                |   9 +- 3 files
> > changed, 263 insertions(+), 64 deletions(-)
> >
> 
> Can you please include a patchset changelog here? What changed between
> v2 and v3?
> 

I will.

Thanks,
Gilad

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/