MIME-Version: 1.0
In-Reply-To: <54d8f5b3325925e60b@agluck-desk.sc.intel.com>
References: <20150209110149.GC4051@pd.tnic>
	<54d8f5b3325925e60b@agluck-desk.sc.intel.com>
Date: Wed, 11 Feb 2015 10:11:00 -0800
Message-ID: <CA+8MBbJc8ed898L_JgHetv7EdVTo6EyMiyKv+=neUtU79=gkBw@mail.gmail.com>
Subject: Re: [PATCHv3] x86/mce: Fix regression. All error records should
 report via /dev/mcelog
From: Tony Luck <tony.luck@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: X86-ML <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Edac Mailing List <linux-edac@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1652
Lines: 35

On Mon, Feb 9, 2015 at 10:00 AM, Tony Luck <tony.luck@intel.com> wrote:
> I'm getting complaints from validation teams that have updated their
> Linux kernels from ancient versions to current. They don't see the
> error logs they expect. I tell the to unload any EDAC drivers[1], and
> things start working again.  The problem is that we short-circuit
> the logging process if any function on the decoder chain claims to
> have dealt with the problem:
>
>         ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m);
>         if (ret == NOTIFY_STOP)
>                 return;
>
> The logic we used when we added this code was that we did not want
> to confuse users with double reports of the same error.
>
> But it turns out users are not confused - they are upset that they
> don't see a log where their tools used to find a log.
>
> I could also get into a long description of how the consumer of this
> log does more than just decode model specific details of the error.
> It keeps counts, tracks thresholds, takes actions and runs scripts
> that can alert administrators to problems.
>
> [1] We've recently compounded the problem because the acpi_extlog
> driver also registers for this notifier and also returns NOTIFY_STOP.

So I see that this missed the x86/ras pull request to Linus.  Will you be doing
another one this merge window?  Or should I just send this direct to Linus?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/