Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754326AbbBKVIv (ORCPT ); Wed, 11 Feb 2015 16:08:51 -0500 Received: from pmta1.delivery1.ore.mailhop.org ([54.191.214.3]:56105 "EHLO pmta1.delivery1.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbbBKVIS (ORCPT ); Wed, 11 Feb 2015 16:08:18 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+ZUr1+thXGeZkJovXl72nz Date: Wed, 11 Feb 2015 12:26:12 -0800 From: Tony Lindgren To: Jon Hunter Cc: Paul Walmsley , Jon Hunter , linux-omap@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org, "aaro.koskinen@iki.fi >> Aaro Koskinen" , tuukka.tikkanen@linaro.org, "khilman@deeprootsystems.com >> Kevin Hilman" , "linux@arm.linux.org.uk >> Russell King" Subject: Re: [PATCH] ARM: OMAP1: PM: fix some build warnings on 1510-only Kconfigs Message-ID: <20150211202611.GF2531@atomide.com> References: <54D9CFBC.3070405@nvidia.com> <54D9E42C.7010105@gmail.com> <54DB93DA.8050308@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DB93DA.8050308@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 33 * Jon Hunter [150211 09:43]: > > Thinking about this some more, I don't understand the dependency on the > DM_TIMER here. For an omap1 device, regardless of whether the DM_TIMERs > are enable or not, the device should be able to enter low power if the > 32K is enabled. Hence, shouldn't this have been !(CONFIG_OMAP_32K_TIMER) > above? Sounds about right, there are separate timers on omap1 and additional gp timers. There's no 32KiHz timer on 1510 variants, including 720 and 730. > Furthermore, you will get the above warning on a omap16xx only build if > you disable DM_TIMERs and keep MPU_TIMER enabled, which should be a > valid thing to do. > > Tony, I see you added the DM_TIMER dependency in commit > be26a008414414c69a4ae9fe9877401c3ba62c5a. I understand your motivation, > but why not just use !(CONFIG_OMAP_32K_TIMER) here? Bit 9 of the idlect1 > is only for the TIMCK clock that is used for the MPU timers and not the > DM_TIMERs. Hmm yes looks like you're right. That check be done based on !CONFIG_OMAP_32K_TIMER like you're saying. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/