Message-ID: <1423687383.15343.22.camel@perches.com>
Subject: Re: checkpatch induced patches...
From: Joe Perches <joe@perches.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        gmate.amit@gmail.com, Greg KH <gregkh@linuxfoundation.org>,
        Bas Peters <baspeters93@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Pushpendra Singh <pushpendra.singh@smartplayin.com>,
        manuel.schoelling@gmx.de, Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Kalle Valo <kvalo@qca.qualcomm.com>
Date: Wed, 11 Feb 2015 12:43:03 -0800
In-Reply-To: <20150211202441.GD29636@amd>
References: <1423573373-820-2-git-send-email-pushpendra.singh@smartplayin.com>
	 <20150210141307.GB15593@sudip-PC>
	 <CAOgR63foxcQtLaaS+vEQ2BKtgHGoQHn1xiLSv=4YZf=Dy6oG3w@mail.gmail.com>
	 <20150211083328.GJ5206@mwanda> <1423647637.15343.16.camel@perches.com>
	 <20150211105122.GN5206@mwanda> <1423677629.15343.18.camel@perches.com>
	 <20150211183615.GQ5206@mwanda>
	 <CAFLxGvzY=uZcoa1rCJSqokLfDgXtZ=-sD6mc638Qxh-HDwYwXw@mail.gmail.com>
	 <1423686025.15343.20.camel@perches.com> <20150211202441.GD29636@amd>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2066
Lines: 49

On Wed, 2015-02-11 at 21:24 +0100, Pavel Machek wrote:
> On Wed 2015-02-11 12:20:25, Joe Perches wrote:
> > On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
> > > On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > > > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
> > > >> I'm half tempted to submit some patch like this to
> > > >> make it difficult to use checkpatch on files outside
> > > >> of drivers/staging.
> > > >> o Only allow checkpatch to be used with the -f/--file
> > > >>   option for drivers/staging/
> > > >> o Add an undocumented --force command line option
> > > > Sure.  We could try that.  I once sent a patch to make -f generate a
> > > > warning about not wasting people's time, but this is also ok.
> > > >> o Make --strict the default for drivers/staging
[]
> > > FYI: We had already a heated debate on that topic.
> > > https://lkml.org/lkml/2014/7/17/415
[]
> > This is basically a patch that implements my suggestion
> > in that thread.
> > https://lkml.org/lkml/2014/7/17/427
> > 
> > I wonder if the undocumented --force option is acceptable
> > to Pavel and Kalle.

> Undocumented options are evil... You can add warning about not wasting
> people's time in --force documentation...

Yeah, I had added --force to the help text
then removed it before sending, so I suppose
adding a warning there is OK too.

Nobody reads the --help text anyway.

Dan/Andrew/Greg?  You got a preference?

Maybe some help/warning text like:

  --force                    Without --force, checkpatch will not scan files
                             using -f or --file outside of drivers/staging/...
                             Do not use this option merely to create potential
                             patches that are uncompiled or untested.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/