Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512AbbBKVb1 (ORCPT ); Wed, 11 Feb 2015 16:31:27 -0500 Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:36156 "HELO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753416AbbBKVb0 convert rfc822-to-8bit (ORCPT ); Wed, 11 Feb 2015 16:31:26 -0500 MIME-Version: 1.0 In-Reply-To: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> References: <1423650218-24666-1-git-send-email-geert@linux-m68k.org> Date: Wed, 11 Feb 2015 13:31:20 -0800 Message-ID: Subject: Re: [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun() From: Pravin Shelar To: Geert Uytterhoeven Cc: "David S. Miller" , Thomas Graf , netdev , "dev@openvswitch.org" , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 19 On Wed, Feb 11, 2015 at 2:23 AM, Geert Uytterhoeven wrote: > net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’: > net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function > > If ipv4_tun_from_nlattr() returns a different positive value than > OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and > validate_and_copy_set_tun() may return an undefined value instead of a > zero success indicator. Initialize err to zero to fix this. > > Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension") > Signed-off-by: Geert Uytterhoeven Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/