Date: Wed, 11 Feb 2015 14:41:05 -0800 (PST)
Message-Id: <20150211.144105.402784068369724984.davem@davemloft.net>
To: geert@linux-m68k.org
Cc: pshelar@nicira.com, tgraf@suug.ch, netdev@vger.kernel.org,
        dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openvswitch: Add missing initialization in
 validate_and_copy_set_tun()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1423650218-24666-1-git-send-email-geert@linux-m68k.org>
References: <1423650218-24666-1-git-send-email-geert@linux-m68k.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 843
Lines: 16

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 11 Feb 2015 11:23:38 +0100

> net/openvswitch/flow_netlink.c: In function ?validate_and_copy_set_tun?:
> net/openvswitch/flow_netlink.c:1749: warning: ?err? may be used uninitialized in this function
> 
> If ipv4_tun_from_nlattr() returns a different positive value than
> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
> validate_and_copy_set_tun() may return an undefined value instead of a
> zero success indicator. Initialize err to zero to fix this.
> 
> Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?