Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754419AbbBLAfU (ORCPT ); Wed, 11 Feb 2015 19:35:20 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:38427 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859AbbBLAfS (ORCPT ); Wed, 11 Feb 2015 19:35:18 -0500 Date: Wed, 11 Feb 2015 16:35:11 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Christoph Lameter cc: akpm@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, iamjoonsoo@lge.com, Jesper Dangaard Brouer Subject: Re: [PATCH 1/3] Slab infrastructure for array operations In-Reply-To: Message-ID: References: <20150210194804.288708936@linux.com> <20150210194811.787556326@linux.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 28 On Wed, 11 Feb 2015, Christoph Lameter wrote: > > > > Hmm, not sure why the allocator would be required to do the > > > > EXPORT_SYMBOL() if it defines kmem_cache_free_array() itself. This > > > > > > Keeping the EXPORT with the definition is the custom as far as I could > > > tell. > > > > > > > If you do dummy functions for all the allocators, then this should be as > > simple as unconditionally defining kmem_cache_free_array() and doing > > EXPORT_SYMBOL() here and then using your current implementation of > > __kmem_cache_free_array() for mm/slab.c. > > That works if I put an EXPORT_SYMBOL in mm/slab_common.c and define the > function in mm/slub.c? > No, my suggestion was for the same pattern as kmem_cache_alloc_array(). In other words, I think you should leave the definition of kmem_cache_free_array() the way it is in your patch, remove the #ifndef since _HAVE_SLAB_ALLOCATOR_ARRAY_OPERATIONS is going away, and then define a __kmem_cache_free_array() for each allocator. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/