Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932150AbbBLDvF (ORCPT ); Wed, 11 Feb 2015 22:51:05 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:59962 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbbBLDvE (ORCPT ); Wed, 11 Feb 2015 22:51:04 -0500 MIME-Version: 1.0 In-Reply-To: <1423637528-29418-1-git-send-email-hofrat@osadl.org> References: <1423637528-29418-1-git-send-email-hofrat@osadl.org> Date: Thu, 12 Feb 2015 11:51:02 +0800 Message-ID: Subject: Re: [PATCH RFC] blackfin: make timeout HZ independent From: Steven Miao To: Nicholas Mc Guire Cc: Christoph Lameter , Tejun Heo , bfin , "open list:CAN NETWORK DRIVERS , open list:NETWORKING DRIVERS , open list" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 44 Applied. Thanks. On Wed, Feb 11, 2015 at 2:52 PM, Nicholas Mc Guire wrote: > The timeout is in jiffies so the hard-coded numeric value becomes HZ > dependent, which is probably not the intent. To resolve this the > timeout is converted with msecs_to_jiffies. > > Signed-off-by: Nicholas Mc Guire > --- > > Due to tool-chain problems this patch was not even compile tested, further > it is unclear if the interpretation of 5000 as 5000 milliseconds is even > correct it is based on looking at other archs (e.g arch/arm64/kernel/smp.c, > arch/arm/kernel/smp.c...) which use msecs_to_jiffies(5000), but other > architectures use completely different timeouts. I think msecs_to_jiffies(5000) is ok, we will test it on our bf561 board. > > Patch is against 3.19.0 (localversion-next is -next-20150210) > > arch/blackfin/mach-common/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/blackfin/mach-common/smp.c b/arch/blackfin/mach-common/smp.c > index 8ad3e90..8a05c32 100644 > --- a/arch/blackfin/mach-common/smp.c > +++ b/arch/blackfin/mach-common/smp.c > @@ -417,7 +417,7 @@ static DECLARE_COMPLETION(cpu_killed); > > int __cpu_die(unsigned int cpu) > { > - return wait_for_completion_timeout(&cpu_killed, 5000); > + return wait_for_completion_timeout(&cpu_killed, msecs_to_jiffies(5000)); > } > > void cpu_die(void) > -- > 1.7.10.4 > -steven -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/