Message-ID: <54DC3086.5030603@linux.intel.com>
Date: Thu, 12 Feb 2015 12:48:06 +0800
From: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, pavel@ucw.cz,
        len.brown@intel.com, linux-pm@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase
References: <54DB6A81.3040706@linux.intel.com> <5368734.2g4GXN33HR@vostro.rjw.lan>
In-Reply-To: <5368734.2g4GXN33HR@vostro.rjw.lan>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1767
Lines: 39


On 2015/2/11 23:25, Rafael J. Wysocki wrote:
> On Wednesday, February 11, 2015 10:43:13 PM Fu, Zhonghui wrote:
>> From 2626594c03ca3b9884dd44073385c36f99a3651d Mon Sep 17 00:00:00 2001
>> From: Zhonghui Fu <zhonghui.fu@linux.intel.com>
>> Date: Wed, 11 Feb 2015 16:20:21 +0800
>> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase
> Can you please avoid putting the above header lines into your patches?
>
> The only one that may be necessary is the From: line, but that's only
> needed if you submit from a different address.
>
> Also please don't send To: mailing lists.  Use CC instead.  In fact, there
> should be *one* address in the To: field when you're submitting a patch:
> The address of the maintainer you want to apply the patch for you.
Thanks for your guidance, and I will re-send this patch.

>
>> Occasionally, the system can't come back up after suspend/resume
>> due to problems of device suspending phase. This patch make
>> PM_TRACE infrastructure cover device suspending phase of
>> suspend/resume process, and the information in RTC can tell
>> developers which device suspending function make system hang.
> Do you have any examples of when this helped and no other debug methods did?
>
> It seems odd to me that no one has ever asked for this for several years and
> now you need it.
We ever run into some system hang during suspending some devices on BayTrail-T platform such as DMA, audio, etc. So, extending PM-Trace to suspend phase should be helpful.

Thanks,
Zhonghui
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/