Date: Thu, 12 Feb 2015 10:16:10 +0100
From: Borislav Petkov <bp@alien8.de>
To: Scotty Bauer <sbauer@eng.utah.edu>, "H. Peter Anvin" <hpa@zytor.com>
Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org,
        x86@kernel.org
Subject: Re: [PATCH] x86/smpboot: check if CLFLUSH is actually necessary
Message-ID: <20150212091610.GA24269@pd.tnic>
References: <54CBF6F9.5040508@eng.utah.edu>
 <54DBCFD6.8000509@zytor.com>
 <54DBE154.5040204@eng.utah.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <54DBE154.5040204@eng.utah.edu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 25

On Wed, Feb 11, 2015 at 04:10:12PM -0700, Scotty Bauer wrote:
> Do you get the same effect? Sure, but is the previous way the right
> way to do it? In my opinion no, but I'm not the one merging code
> its up to someone more experienced to determine if the change is
> warranted. The change is slightly faster on non-buggy cpu, but like
> you mention, is that relevant when the machine is going into idle?

Right, it probably doesn't matter on the way to idle but we could do the
change just to make the code the same as in mwait_idle_with_hints() so
that there are no more why-is-this-different questions in the future.

Or even make it a small function called prepare_monitor() and put the
if-check in there and call that function in both places...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/